MLP: Fix step size initialization based on learning rate policy #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: MADLIB-1212 The step_size is supposed to be updated based on the learning rate. The formulae for different policies depend on the current iteration number, which was not consumed correctly. This commit fixes it by using it.iteration for the current iteration number in that update. Co-authored-by: Nikhil Kak <nkak@pivotal.io>
|
Refer to this link for build results (access rights to CI server needed): |
kaknikhil
reviewed
Mar 16, 2018
| @@ -112,6 +112,7 @@ def mlp(schema_madlib, source_table, output_table, independent_varname, | |||
| num_output_nodes = 0 | |||
| classes = [] | |||
| dependent_type = get_expr_type(dependent_varname, source_table) | |||
| classes_str = None | |||
There was a problem hiding this comment.
we don't really need this classes_str variable, right ?
|
Refer to this link for build results (access rights to CI server needed): |
|
We manually tested the bug fix by printing the step_size and step_size_init for each iteration and then called mlp with all the possible policies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MADLIB-1212
The step_size is supposed to be updated based on the learning rate. The
formulae for different policies depend on the current iteration number,
which was not consumed correctly. This commit fixes it by using
it.iteration for the current iteration number in that update.
Co-authored-by: Nikhil Kak nkak@pivotal.io