Bugfix: Fix failing dev check in CRF #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has the following changes: - A couple of dev check files in CRF did not have the label table creation in it. But the label table was consumed by one of the queries that led to dev-check failure. - Run dev check on Jenkins build instead of install check.
|
Refer to this link for build results (access rights to CI server needed): |
kaknikhil
requested changes
Jun 27, 2018
|
|
||
| SELECT crf_train_fgen('train_new_segmenttbl', 'train_new_regex', 'crf_label', 'train_new_dictionary', 'train_new_featuretbl','train_new_featureset'); | ||
| CREATE TABLE crf_label_new (id integer,label character varying); |
There was a problem hiding this comment.
The two files crf_test_small.sql_in and crf_train_large.sql_in have different indentation. Can we make them consistent
| @@ -90,7 +90,7 @@ | |||
| (18,'PRP$'),(19,'RB'), (20,'RBR'), (21,'RBS'), (22,'RP'), (23,'SYM'), (24,'TO'), (25,'UH'), (26,'VB'), | |||
| (27,'VBD'), (28,'VBG'),(29,'VBN'), (30,'VBP'), (31,'VBZ'),(32,'WDT'), (33,'WP'), (34,'WP$'),(35,'WRB'), | |||
| (36,'$'), (37,'#'), (38,''''''), (39,'``'), (40,'('), (41,')'), (42,','), (43,'.'), (44,':'); | |||
| analyze crf_label; | |||
| analyze test_crf_label; | |||
There was a problem hiding this comment.
Assuming that the table crf_label doesn't exist, why wasn't crf install check always red?
kaknikhil
requested changes
Jun 27, 2018
There was a problem hiding this comment.
Couple of recommendations:
- Maybe move the jenkins changes to a separate commit since it's unrelated to crf changes.
- The commit message was a bit confusing to read, can we reword it ? I couldn't figure out why the test started failing from reading the commit message.
|
Thank you for the comments @kaknikhil . I moved out the jenkins build script to a different commit. |
kaknikhil
approved these changes
Jun 27, 2018
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has the following changes:
in it. But the label table was consumed by one of the queries that led
to dev-check failure.