SVM: Fix flaky dev-check failure #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: MADLIB-1232 SVM has a dev-check query that is flaky on a large cluster. This commit relaxes the assert condition for that query. Closes apache#284
|
This test isn't necessarily the best thing to check but if we do want to keep it with some relaxed constraints then maybe we allow the norm to go higher by a small amount iff the total loss is lower. So something along the lines of |
|
Thank you for the comment @iyerr3 , will relax the constraint as suggested. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
orhankislal
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MADLIB-1232
SVM has a dev-check query that is flaky on a large cluster. This commit
relaxes the assert condition for that query.
Closes #284