Fix false positive for Postgres 10+ #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to mistake 9.3.24 as a higher version than Postgres 10 and stop matching it to the correct "port". This patch fixes that.
|
Refer to this link for build results (access rights to CI server needed): |
iyerr3
reviewed
Sep 13, 2018
| @@ -82,8 +82,7 @@ function(determine_target_versions OUT_VERSIONS) | |||
| set(VERSION "4.3ORCA") | |||
| endif() | |||
| elseif(${PORT_UC} STREQUAL "POSTGRESQL" AND | |||
| (${${PORT_UC}_VERSION_MAJOR} EQUAL 10 OR | |||
| ${${PORT_UC}_VERSION_PATCH} GREATER 10)) | |||
There was a problem hiding this comment.
The intention was to check for ...VERSION_MAJOR >= 10. Hence the two checks - there was, however a typo with the second version input as ...PATCH instead of ...MAJOR. The correction should be to replace the _PATCH with _MAJOR.
There was a problem hiding this comment.
@d Do you mind if I merge this with the minor change (as described above)?
There was a problem hiding this comment.
oops now I understand why the GREATER check was there! Yeah go ahead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to mistake 9.3.24 as a higher version than Postgres 10 and stop
matching it to the correct "port". This patch fixes that.