[ARCHETYPE-311] Add feature to create base dir #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP: test
albfan
reviewed
Feb 2, 2020
...mon/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
Show resolved
Hide resolved
ripper2hl
changed the title
elharo
reviewed
Apr 16, 2020
michael-o
requested changes
Apr 16, 2020
| return createBaseDir; | ||
| } | ||
|
|
||
| public ArchetypeGenerationRequest setCreteBaseDir( boolean createBaseDir ) |
There was a problem hiding this comment.
@michael-o you can review now, please
|
This a related jira issue , i don't know if what is you need @elharo . |
elharo
changed the title
|
@ripper2hl ARCHETYPE-311 doesn't seem to be for this. It is in the same area, but 311 is a bug "Basedir property in archetype:generate cannot be overriden", not a new feature. Does this fix the bug and add a feature? |
|
@dhutchison this add the posibilty to create an project on the same directory, without create an subdirectory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now when you create an project always generate a directory with the name of the artifact but in some case this is not required.
You can see https://stackoverflow.com/questions/24399613/using-maven-archetype-generate-in-the-same-directory
Work-in-Progress.
If this a bad approach let me know please.