Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASSEMBLY-974] Drop deprecated repository element #113

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Feb 22, 2023

As a followup for deprecation MASSEMBLY-957 in version 3.4.0, the deprecated element is being dropped.

As a consequence, this removes deprecated MAT as well.

--

https://issues.apache.org/jira/browse/MASSEMBLY-974

As a followup for deprecation MASSEMBLY-957 in version 3.4.0,
the deprecated element is being dropped.

As a consequence, this removes deprecated MAT as well.

--

https://issues.apache.org/jira/browse/MASSEMBLY-974
@cstamas cstamas self-assigned this Feb 22, 2023
@cstamas
Copy link
Member Author

cstamas commented Feb 22, 2023

On my workstation one IT fails, the projects/reproducible, unsure why. Failure is:

assert content == effective
       |       |  |
       |       |  40755 dir-A/
       |       |  40755 dir-C/
       |       |  40755 dir-b/
       |       |  40755 dir-b/B2/
       |       |  40755 dir-b/B4/
       |       |  40755 dir-b/b1/
       |       |  40755 dir-b/b3/
       |       |  40755 dir-d/
       |       |  100664 Uppercase.txt
       |       |  100664 dir-A/A2.txt
       |       |  100664 dir-A/A4.txt
       |       |  100664 dir-A/a1.txt
       |       |  100664 dir-A/a3.txt
       |       |  100664 dir-C/C.txt
       |       |  100664 dir-b/B2/B2.txt
       |       |  100664 dir-b/B4/B4.txt
       |       |  100664 dir-b/b.txt
       |       |  100664 dir-b/b1/b1.txt
       |       |  100664 dir-b/b3/b3.txt
       |       |  100664 dir-d/d.txt
       |       |  100775 executable.txt
       |       |  100664 lowercase.txt
       |       |  2456cb51390a059bf9b93cba4a0e0fc8f6bcf038 reproducible-1.0-src.zip.sha1
       |       |  2437692cda28c00d3c34936104ead651a6a348e1 reproducible-1.0-src.jar.sha1
       |       |  c6a6ab2d2a9bc040ecb5925ee2df4b5ec63194d0 reproducible-1.0-src.tar.sha1
       |       false
       40775 dir-A/
       40775 dir-C/
       40775 dir-b/
       40775 dir-b/B2/
       40775 dir-b/B4/
       40775 dir-b/b1/
       40775 dir-b/b3/
       40775 dir-d/
       100664 Uppercase.txt
       100664 dir-A/A2.txt
       100664 dir-A/A4.txt
       100664 dir-A/a1.txt
       100664 dir-A/a3.txt
       100664 dir-C/C.txt
       100664 dir-b/B2/B2.txt
       100664 dir-b/B4/B4.txt
       100664 dir-b/b.txt
       100664 dir-b/b1/b1.txt
       100664 dir-b/b3/b3.txt
       100664 dir-d/d.txt
       100775 executable.txt
       100664 lowercase.txt
       50116502c6107740c2a35ef296b5abda08c5dec7 reproducible-1.0-src.zip.sha1
       cc7e3a984179f63d6b37bc86c61e9cc461c62288 reproducible-1.0-src.jar.sha1
       3efc10ec9c3099ba061e58d5b2a935ba643da237 reproducible-1.0-src.tar.sha1

Edit: failure on my WS is always the same, hence build seems reproducible on my WS as well, but the test assertion missed to figure out that.

@@ -226,7 +226,7 @@
</field>
<field>
<name>repositories</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove also repositories from model as we remove it from code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did I miss range from class? As field is gone, that's sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@michael-o michael-o removed their request for review March 1, 2023 10:05
@cstamas cstamas merged commit 6c7b43c into master Mar 24, 2023
@cstamas cstamas deleted the MASSEMBLY-974-drop-repo branch March 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants