Refactored code for Maven Assembly Plugin. No code breaks, all test cases passing. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
requested changes
Apr 26, 2023
| } | ||
|
|
||
| return first; | ||
| // Refactored using extract class. created new class RootPrefix |
| @@ -159,4 +123,19 @@ public InputStreamTransformer getStreamTransformer() { | |||
| public FileMapper[] getFileMappers() { | |||
| return EMPTY_FILE_MAPPERS_ARRAY; | |||
| } | |||
|
|
|||
| static FileSelector[] combineSelectors(FileSelector[] first, FileSelector[] second) { | |||
There was a problem hiding this comment.
looks not changed - please don't change position
|
|
||
| return rootPrefix + prefix; | ||
| // Refactored using extract class. created new class PrefixedPrefix | ||
| return new PrefixedPrefix(rootPrefix, prefix).getValue(); |
There was a problem hiding this comment.
code used in one place - I don't see benefit to extract
|
|
||
| return first; | ||
| // Refactored using extract class. created new class RootPrefix | ||
| this.rootPrefix = new RootPrefix(rootPrefix).getValue(); |
There was a problem hiding this comment.
code used in one place - I don't see benefit to extract
| @@ -92,7 +92,7 @@ private static boolean isForbiddenFiletypes(PlexusIoResource plexusIoResource) { | |||
| return (fileName.endsWith(".zip") || fileName.endsWith(".jar")); | |||
| } | |||
|
|
|||
| private static void checkifFileTypeIsAppropriateForLineEndingTransformation(PlexusIoResource plexusIoResource) | |||
| /* private static void checkifFileTypeIsAppropriateForLineEndingTransformation(PlexusIoResource plexusIoResource) | |||
There was a problem hiding this comment.
We don't need preserve old code as comment
|
probable bot spam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the code using following techniques in the mentioned classes:
Refactoring name: Extract Method
Location: src/main/java/org/apache/maven/plugins/assembly/utils/AssemblyFileUtils.java
Line 69
Refactoring name: Introduce explaining variable
Location: src/main/java/org/apache/maven/plugins/assembly/mojos/SingleAssemblyMojo.java
Line 71
Refactoring name: Rename Method
Location: src/main/java/org/apache/maven/plugins/assembly/format/ReaderFormatter.java
Line 95
Refactoring name: Replace conditional with Polymorphism
Location: src/main/java/org/apache/maven/plugins/assembly/io/DefaultMessageHolder.java
Line 514
Refactoring name: Extract Class
Location: src/main/java/org/apache/maven/plugins/assembly/archive/archiver/PrefixedFileSet.java
Line 46 and 82
Made new classes
RootPrefix.java: src/main/java/org/apache/maven/plugins/assembly/archive/archiver/RootPrefix.java
Prefix Prefixed.java: src/main/java/org/apache/maven/plugins/assembly/archive/archiver/PrefixedPrefix.java
Location: FileLocation.java: src/main/java/org/apache/maven/plugins/assembly/io/FileLocation.java
Line 145
URLLocation.java: src/main/java/org/apache/maven/plugins/assembly/io/URLLocation.java
Line 81