Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI #37

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Jan 13, 2023

This allows this plugin to be enabled on the CLI with

-Dmaven.build.cache.enabled=true

when it is disabled by default in the XML.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@ahus1
Copy link
Contributor Author

ahus1 commented Jan 13, 2023

I'm looking forward to have this feature in a patch release as it would allow me to use this extension "opt in" for the developers of the Keycloak project. Thanks!

@olamy olamy added the enhancement New feature or request label Feb 10, 2023
@ahus1
Copy link
Contributor Author

ahus1 commented Feb 10, 2023

I'm happy to see those approvals above. Once this is merged and available as a release (even a pre-release), I'll be able to canary-test this with some users on our project. Let me know how I can help. Thanks!

@olamy olamy merged commit f91a4d4 into apache:master Feb 13, 2023
@gnodet gnodet added this to the 1.0.1 milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants