Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary I/O indirections #119

Merged
merged 2 commits into from
May 21, 2023
Merged

remove unnecessary I/O indirections #119

merged 2 commits into from
May 21, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 20, 2023

Maven conventions make PlexusTestCase.getBasedir() unnecessary. It's effectively constant.

@elharo elharo changed the title remove unnecessary code remove unnecessary I/O code May 20, 2023
@elharo elharo changed the title remove unnecessary I/O code remove unnecessary I/O indirections May 20, 2023
@elharo elharo requested a review from michael-o May 20, 2023 15:08
@elharo elharo marked this pull request as ready for review May 20, 2023 15:08
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they really identical?

@elharo elharo merged commit 472ed5a into master May 21, 2023
12 checks passed
@elharo elharo deleted the dep branch May 21, 2023 11:56
@elharo
Copy link
Contributor Author

elharo commented May 21, 2023

If you build with Maven, which this project does, they are. Possibly getBaseDir might be more useful if a project were setup using ant or something else that didn't follow Maven's source layout conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants