Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCOMPILER-488] dedicated option for implicit javac flag #102

Merged
merged 2 commits into from
Mar 18, 2022
Merged

[MCOMPILER-488] dedicated option for implicit javac flag #102

merged 2 commits into from
Mar 18, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Mar 13, 2022 •
edited
Loading

@pzygielo pzygielo mentioned this pull request Mar 13, 2022
Merged
@pzygielo pzygielo changed the title [MCOMPILER-402] Pass implicit configuration down to compiler [MCOMPILER-402] Pass implicit configuration down to compiler Mar 13, 2022
@olamy
Copy link
Member

olamy commented Mar 16, 2022

@pzygielo plexus-compiler changes merged and 2.11.2-SNAPSHOT so you can mark it as ready ;)

@pzygielo pzygielo marked this pull request as ready for review March 16, 2022 08:11
@pzygielo
Copy link
Contributor Author

@olamy - thanks for checking (and pushing plexus-*es).
This has now completed GH workflow and is marked as ready for review.

I added comment to MCOMPILER-402 to update the example. Not sure about that, and I'd rather not have it in this PR.

@pzygielo
Copy link
Contributor Author

Changed my mind about updating example to not needed.

Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new New feature linked to 402. And probably to close 402 as not an issue.

@olamy
Copy link
Member

olamy commented Mar 17, 2022 •
edited
Loading

Changed my mind about updating example to not needed.

Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new New feature linked to 402. And probably to close 402 as not an issue.

agree. a new jira as a feature would be nice.
and an IT?

@pzygielo pzygielo changed the title [MCOMPILER-402] Pass implicit configuration down to compiler [MCOMPILER-488] Pass implicit configuration down to compiler Mar 17, 2022
@pzygielo pzygielo marked this pull request as draft March 17, 2022 06:25
@pzygielo pzygielo changed the title [MCOMPILER-488] Pass implicit configuration down to compiler [MCOMPILER-488] dedicated option for implicit javac flag Mar 17, 2022
@pzygielo
Copy link
Contributor Author

Switched to new ticket.

@pzygielo pzygielo marked this pull request as ready for review March 17, 2022 13:06
@olamy olamy merged commit 785089d into apache:master Mar 18, 2022
@pzygielo pzygielo deleted the MCOMPILER-402 branch March 18, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@pzygielo @olamy