Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-495] - Fixes missing dirs in createMissingPackageInfoClasses #121

Merged
merged 1 commit into from
May 30, 2022

Conversation

jmax01
Copy link
Contributor

@jmax01 jmax01 commented Apr 29, 2022

In createMissingPackageInfoClasses if the target directory does not contain the parent path of a package-info.class file create the directories before attempting to write the package-info.class file

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy added the bug label Apr 30, 2022
@olamy olamy merged commit c40f5fd into apache:master May 30, 2022
@olamy olamy changed the title MCOMPILER-495 - Fixes missing dirs in createMissingPackageInfoClasses [MCOMPILER-495] - Fixes missing dirs in createMissingPackageInfoClasses Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants