Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-499] display recompilation causes #143

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Jul 28, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

ledoyen and others added 2 commits July 27, 2022 16:37
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit 413dbb7 into master Jul 28, 2022
@olamy olamy deleted the MCOMPILER-499_display_recompilation_causes branch July 28, 2022 21:18
@ledoyen
Copy link
Contributor

ledoyen commented Jul 29, 2022

Thanks @olamy, being currently AFK, I did not see your request in time. Hopefully this will allow users to understand and optimize their build reactor. Good job 👍

@olamy olamy changed the title MCOMPILER 499 display recompilation causes [MCOMPILER-499] display recompilation causes Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants