Miscellaneous code cleanups #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
May 4, 2019
|
If you want a Jira ticket for these changes let me know and I'll make one and rewrite the commits |
|
Please create some of them... |
As per the Java specification, x instanceof y will return false if x is null: https://docs.oracle.com/javase/specs/jls/se11/html/jls-15.html#jls-15.20.2
eolivelli
approved these changes
May 5, 2019
|
OK, I made 4 tickets for the 4 classes of change & rewrote the commit messages. There are a bunch of DOS format files in the repo - any objection to a PR that converts them all to unix line ending and then leave git to do the right thing for all platforms? |
|
@eolivelli sorry for the nudge - how's this change looking? |
It looks great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the result of running the IntelliJ linter and picking the juiciest looking changes.
Hopefully there's nothing too contentious here - see individual commits for details.
Addresses
MCOMPILER-382
MCOMPILER-383
MCOMPILER-384
MCOMPILER-385
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004