[MCOMPILER-525] Incorrect detection of dependency change

[jorsol]

This fix a bug with the incremental compilation related to the incorrect detection of the project classes as a dependency.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[olamy]

@jorsol thanks for your PR. is your issue fixed if you try this PR https://github.com/apache/maven-compiler-plugin/pull/172/files#r1090053416?
because I'm a bit scared of the performance impact of some changes here

[jorsol]

Hi @olamy, the issue is not fixed with the PR #163.

I haven't done any performance testing, but I'm sure this will be more performant than the current code, yet I could check and improve the code further if needed.

[jorsol]

@slawekjaranowski @olamy I think I have addressed all the comments, even I end up basically fixing the issue MCOMPILER-381 too.

There are a lot of other improvements that can be made, refactor legacy code, and more, but for now I don't want to keep touching and touching this (every time I look I end up making some small refactor), this should be a good improvement so far, as of performance concerns this should be at least equally performant than the previous code.

[gnodet]

@jorsol I have a hard time understanding the exact change that fixes the problem. Would it be possible to have a first commit that refactors the code using the nio api and other improvements, and another commit with the actual fix for the problem ?

Note that we could also embeds the trimmed down version of the IncrementalBuildHelper.

[jorsol]

I have a hard time understanding the exact change that fixes the problem.

@gnodet sure, the fix for this issue is trivial, so I undo all the refactoring and only provide the actual fix.

[jorsol]

Thanks @gnodet , I will open the refactor PR for MCOMPILER-381 that was previously done here ASAP and then later I could check if I could use the IncrementalBuildHelper mentioned if time allows me.