Cleanup debug log handling #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're already inside an if that checked it
rfscholte
reviewed
May 27, 2019
| @@ -960,7 +963,7 @@ else if ( CompilerConfiguration.CompilerReuseStrategy.ReuseSame.getStrategy().eq | |||
| } | |||
|
|
|||
| String[] cl = compiler.createCommandLine( compilerConfiguration ); | |||
| if ( getLog().isDebugEnabled() && cl != null && cl.length > 0 ) | |||
| if ( cl != null && cl.length > 0 ) | |||
There was a problem hiding this comment.
I would prefer to keep the getLog().isDebugEnabled() here, otherwise a lot a String concatenation is done for showing the commandline, which is only shown during debug
There was a problem hiding this comment.
We've already performed this check here: https://github.com/apache/maven-compiler-plugin/pull/21/files#diff-d4e94a0220ac4630c8e2ca12df1b46bcR929
|
Should this change have a Jira ticket? |
|
I've merged it, I don't think we'll make anybody happy when such tiny improvements end up in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make better use of
isDebugEnabled(). See individual commits for details.The diff looks better if you ignore whitespace changes.