Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CompilerMojo#getSourceInclusionScanner(String) illogical addAll #243

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented May 29, 2024

Sonar identified that usage of addAll in CompilerMojo#getSourceInclusionScanner(String) was illogical - i.e. adding excludesIncr into itself:

Set<String> excludesIncr = new HashSet<>(excludes);
excludesIncr.addAll(excludesIncr);

This was introduced in #141, and the same snippet is used in multiple places - only one has this defect, which I suspect is a copy-paste error.

Changes:

  • updated to be consistent with the other examples
  • removed the this. qualifier, as the existing incrementalExcludes access in the same method doesn't use it to be consistent

I am not aware of any defect arising from this issue.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.


To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet gnodet changed the title (doc) Address CompilerMojo#getSourceInclusionScanner(String) illogical addAll Fix CompilerMojo#getSourceInclusionScanner(String) illogical addAll Jul 2, 2024
@gnodet gnodet added this to the 4.0.0 milestone Jul 2, 2024
@JackPGreen
Copy link
Contributor Author

@gnodet thanks for the approval - are you able to merge, please?

@gnodet gnodet merged commit 419f1b6 into apache:master Jul 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants