Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCOMPILER-359 - Fix for NPE #28

Merged
merged 1 commit into from Dec 18, 2019
Merged

MCOMPILER-359 - Fix for NPE #28

merged 1 commit into from Dec 18, 2019

Conversation

hohwille
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MCOMPILER-359 filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MPH-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MPH-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why: pathException.getValue().getCause() may already be null
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically. - I expect you to have a CI setup (e.g. travis)
  • You have run the integration tests successfully (mvn -Prun-its clean verify). - I expect you to have a CI setup (e.g. travis).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hohwille
Copy link
Contributor Author

Indeed no CI present - Incredible. I thought the ASF would be more sophisticated than my personal OSS projects...

@rfscholte
Copy link
Contributor

@rfscholte
Copy link
Contributor

Can you expand the integrationtest of src/it/MCOMPILER-360 ?

@hohwille
Copy link
Contributor Author

hohwille commented Dec 17, 2019

good to know that CI is present. Thanks for the link. You can even integrate Jenkins with github, though...

Can you expand the integrationtest of src/it/MCOMPILER-360 ?

To be honest. I do not know how. My problem is that I would like to figure out the actual exception that was caused. Due to this NPE that is triggered instead, I am unable to see what is going wrong as the important stacktrace is finally lost. As I can only reproduce the error in travis-ci and not locally, I am completely lost. Here is my travis log:
https://api.travis-ci.org/v3/job/626312654/log.txt

It would be awesome to figure out what is really going wrong. However, I fear that it will take ages till a new version of maven-compiler-plugin is released where the NPE is fixed (no offence, we are all very busy coders - I myself also would urgently need to implement various fixes for flatten-maven-plugin but can not find the time) and I have upgraded to that version so I can see what the actual error is. Any idea how to speed up this analysis?

@rfscholte rfscholte merged commit 116b981 into apache:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants