[MDEP-579] - Add mirrors, proxies and authentication for remote repositories. #19
Conversation
…itories, including Jetty test server.
|
|
||
| mojo.execute(); | ||
|
|
||
| server.stop(); |
There was a problem hiding this comment.
Pls call it within the finally block. This is a typical problem of integration tests that they failed and the server is never stopped.
There was a problem hiding this comment.
I've added the server.stop() to a finally block.
| public void testRemoteRepositoriesAuthentication() | ||
| throws Exception | ||
| { | ||
| org.eclipse.jetty.server.Server server = createServer( 8000 ); |
There was a problem hiding this comment.
A concrete prort cannot be. We use the wildcard port 0.0.0.0 and the client connects to the server's local port.
There was a problem hiding this comment.
I start the server now with a random port, and use server.getURI() to generate the remoteRepositories parameter.
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
We don't need to have a plugin for this. This is enough:
<properties>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
</properties>
| server.setId( "myserver" ); | ||
| server.setUsername( "foo" ); | ||
| server.setPassword( "bar" ); | ||
| settings.addServer(server); |
There was a problem hiding this comment.
add spaces like his: settings.addServer( server )
| @@ -150,4 +192,47 @@ public void testParseRepository() | |||
| // expected | |||
| } | |||
| } | |||
|
|
|||
| private ContextHandler createContextHandler() { | |||
There was a problem hiding this comment.
The same here (spaces).
Bracket should be on a new line:
private ContextHandler createContextHandler()
{
| # under the License. | ||
|
|
||
| # username: password[,rolename ...] | ||
| foo: bar,userrole |
There was a problem hiding this comment.
Empty line added!
|
Fixed in e897911 |
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
This new pull request makes pull request #18 redundant.
It includes now a Jetty server on port 8000 to test the authentication.