[MDEP-716] - TestListClassesMojo logs too much

[raupachz]

Hello there,

attached is a PR for MDEP-716. This is an up-for-grabs issue.

This code uses Mockito and creates a mock of the org.apache.maven.plugin.logging.Log.java. A redirect of System.out is not needed. This has also the nice benefit of argument matching.

---

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[slawekjaranowski]

Are files different?
src/test/resources/unit/list-test/testListClassesNotTransitive.txt
src/test/resources/unit/list-test/testListClassesTransitive.txt

If yes we have the same output for different inputs for transitive...

[raupachz]

Hi @slawekjaranowski

no, the files are the same. I did not check the output. Before the output was just written to System.out without any checking. I treated every unit-test as a separate unit with an individual input file. Made sense to me. Even if this results in duplicate file content.

If org.apache.commons:commons-lang3:3.6 has no transitive dependencies then the output should be the same - to my understanding.

[slawekjaranowski]

If org.apache.commons:commons-lang3:3.6 has no transitive dependencies then the output should be the same - to my understanding.

good understanding,

So I see some improvement here

• test for artifacts without transitive dependencies - as we have now, only test name / description should point such case
• test for artifact with transitive dependencies

of course it is job for next PR