Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEP-826] Upgrade maven-reporting-imp from 3.1.0 to 3.2.0 #246

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

Will check...

@michael-o michael-o self-assigned this Sep 14, 2022
@michael-o michael-o self-requested a review September 14, 2022 08:39
@michael-o
Copy link
Member

I will schedule this for Friday.

@michael-o
Copy link
Member

Looking into now...

@michael-o
Copy link
Member

@slawekjaranowski Added a followup commit. Please have a look. Reasoning is in the commit message.

@slawekjaranowski
Copy link
Member Author

When we don't override outputDirectory - report will be placed in target/site
Now when we are calling report from cli output is stored in target - as you see in IT test

Maybe such change should be done in separate issue, in order to show changing behavior in release notes

@michael-o
Copy link
Member

When we don't override outputDirectory - report will be placed in target/site Now when we are calling report from cli output is stored in target - as you see in IT test

Maybe such change should be done in separate issue, in order to show changing behavior in release notes

I understand your reasoning, but if you look at other reporting plugins the standalone behavior is identical. I agree, let's make it a followup issue.

@michael-o
Copy link
Member

https://issues.apache.org/jira/browse/MDEP-827

I will move the second commit to a separate branch and clean this one up.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated. LGTM.

@slawekjaranowski slawekjaranowski merged commit 87f5200 into master Sep 20, 2022
@slawekjaranowski slawekjaranowski deleted the MDEP-826 branch September 20, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants