Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Apache Commons StringUtil #290

Merged
merged 3 commits into from Mar 23, 2023
Merged

use Apache Commons StringUtil #290

merged 3 commits into from Mar 23, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 5, 2023

No description provided.

@elharo elharo requested a review from olamy March 5, 2023 23:48
@elharo
Copy link
Contributor Author

elharo commented Mar 6, 2023

Failure might be flaky or perhaps platform dependent?

[INFO] -------------------------------------------------
Error: The following builds failed:
Error: * analyze-testDependencyWithNonTestScope/pom.xml
[INFO] -------------------------------------------------

@elharo
Copy link
Contributor Author

elharo commented Mar 6, 2023

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project nonTestScopeTestArtifactsAnalysis: Fatal error compiling: error: release version 1.7 not supported -> [Help 1]

@elharo
Copy link
Contributor Author

elharo commented Mar 6, 2023 •
edited

It does look like the failing CI is broken at head based on other failing PRs

@elharo elharo requested a review from michael-o March 19, 2023 12:26
elharo
elharo commented Mar 23, 2023
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests passing, please review

@elharo elharo merged commit 69840a2 into master Mar 23, 2023
@elharo elharo deleted the string2 branch March 23, 2023 12:26
@slawekjaranowski
Copy link
Member

Maybe it is technically easy change .... but we should report issue for such, and each project should have own issue
Now I see a mess like in #299 - which is connected with issue from MNG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

@olamy olamy Awaiting requested review from olamy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@elharo @slawekjaranowski @michael-o