Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instead of Locale#ENGLISH default and use full locale) #67

Merged
merged 1 commit into from Nov 26, 2022
Merged

[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instead of Locale#ENGLISH default and use full locale) #67

merged 1 commit into from Nov 26, 2022

Conversation

michael-o
Copy link
Member

No description provided.

asfgit pushed a commit that referenced this pull request Nov 12, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
50fcc77 
This closes #67
@michael-o michael-o changed the title Doxiasitetools 271 [DOXIASITETOOLS-271] Overhaul locale support and make telescopic Nov 12, 2022
asfgit pushed a commit that referenced this pull request Nov 13, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
23b9568 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 13, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
2927a85 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 14, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
b2f249f 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 14, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
ec0f537 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 14, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
5ab7259 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 14, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
a675c91 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 14, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
ccb23eb 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 19, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
1a6d554 
This closes #67
asfgit pushed a commit that referenced this pull request Nov 19, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support and make telescopic
bbb7d11 
This closes #67
@michael-o michael-o changed the title [DOXIASITETOOLS-271] Overhaul locale support and make telescopic [DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instead of Locale#ENGLISH default and use full locale) Nov 20, 2022
asfgit pushed a commit that referenced this pull request Nov 20, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
fbe730b 
…d of Locale#ENGLISH default and use full locale)

This closes #67
@michael-o michael-o marked this pull request as ready for review November 20, 2022 21:37
@michael-o
Copy link
Member Author

@hboutemy tested entire chain now with m-site-p, m-r-impl and m-project-info-reports-p. For me, this is good to be. Please have a look.

hboutemy
hboutemy requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I fully understood how merging ("telescoping" if anybody understand this term) happens from most specific variant to region to language happens, bu I proposed to describe what I expect = an equivalent or resource bundles

doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java Outdated Show resolved Hide resolved
doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/SiteTool.java Outdated Show resolved Hide resolved
doxia-integration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site.xml Outdated Show resolved Hide resolved
...gration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site_de_DE_BY.xml Outdated Show resolved Hide resolved
...gration-tools/src/test/resources/unit/site-tool-locales-test/full/src/site/site_de_DE_BY.xml Show resolved Hide resolved
...-integration-tools/src/test/resources/unit/site-tool-locales-test/language/src/site/site.xml Outdated Show resolved Hide resolved
...tegration-tools/src/test/resources/unit/site-tool-locales-test/language/src/site/site_de.xml Outdated Show resolved Hide resolved
michael-o added a commit that referenced this pull request Nov 25, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
a0b03a8 
…d of Locale#ENGLISH default and use full locale)

This closes #67
@michael-o
Copy link
Member Author

@hboutemy rewritten/applied. Please check again.

asfgit pushed a commit that referenced this pull request Nov 25, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
2632063 
…d of Locale#ENGLISH default and use full locale)

This closes #67
asfgit pushed a commit that referenced this pull request Nov 26, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
1316e5b 
…d of Locale#ENGLISH default and use full locale)

This closes #67
@michael-o
Copy link
Member Author

@hboutemy Fixed spots.

asfgit pushed a commit that referenced this pull request Nov 26, 2022
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
ad3b6ce 
…d of Locale#ENGLISH default and use full locale)

This closes #67
@michael-o
[DOXIASITETOOLS-271] Overhaul locale support (make Locale#ROOT instea…
54338f4 
…d of Locale#ENGLISH default and use full locale)

This closes #67
@asfgit asfgit closed this in 54338f4 Nov 26, 2022
@asfgit asfgit merged commit 54338f4 into master Nov 26, 2022
@michael-o michael-o deleted the DOXIASITETOOLS-271 branch November 26, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy hboutemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michael-o @hboutemy @asfgit