[DOXIA-670] Drop dead XdocSink#link(String, String) method

[michael-o]

https://issues.apache.org/jira/browse/DOXIA-670

[michael-o]

Note: This change requires to be dropped:

maven-doxia/doxia-modules/doxia-module-xdoc/src/main/resources/xdoc-2.0.xsd

Lines 2923 to 2935 in 3b1499d

	<xs:element name="source">
	<xs:annotation>
	<xs:documentation source="version">2.0.0</xs:documentation>
	<xs:documentation source="description">
	A source element.
	</xs:documentation>
	</xs:annotation>
	<xs:complexType mixed="true">
	<xs:sequence>
	<xs:any minOccurs="0" maxOccurs="unbounded" processContents="skip"/>
	</xs:sequence>
	</xs:complexType>
	</xs:element>

and release a new version. Alternatively, we'd translate source to <div class="source"><pre>...

[michael-o]

This is now a minimalist version. I will leave the table as is.

[hboutemy]

let's rename this issue into "drop dead link(String, String) code" and have VALIGN removal in a separate issue, with discussion on source also separate

[hboutemy]

it seems that this link(String, String) method is more than "duplicate code": it's dead code that was introduced into Doxia 1.1 and was never called outside the unit test
then I'm all in to remove this dead code and update the associated unit test, with proper Jira issue renaming

on other changes like VALIGN, that are unrelated to this dead code removal, I'd prefer have a separate commit and review to better understand

and I don't understand why there is a discussion on "source", which seems to be completely an unrelated discussion

[michael-o]

@hboutemy Done, completely reduced. Attributes are in another ticket. As for the source. HTML5 has now a source element which collides with Xdoc's source. That is why I decided not to fiddle with at the moment. Forget about it.

[michael-o]

@hboutemy PR redone.

[hboutemy]

thanks for the hard work