[DOXIA-724] Fix order of sink wrappers in pipeline #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Jan 13, 2024
| * @since 2.0.0 | ||
| */ | ||
| Collection<SinkWrapperFactory> getSinkWrapperFactories(); | ||
| List<SinkWrapperFactory> getSinkWrapperFactories(); |
There was a problem hiding this comment.
Is is necessary to change the signature here?
There was a problem hiding this comment.
I think it was a mistake exposing that via Parser. This is clearly SPI only and therefore only belongs to AbstractParser. There it should be a protected method. List as return value makes sense for usages which try to retrieve the last element only. For me M-builds should allow to modify API.
There was a problem hiding this comment.
The drop it from Parser altogether, no?
kwin
force-pushed
the
bugfix/order-of-sink-wrappers
branch
from
1d9828b
to
096190a
Compare
kwin
force-pushed
the
bugfix/order-of-sink-wrappers
branch
from
096190a
to
8ab4481
Compare
michael-o
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.