[DOXIA-731] Simplify HTML markup emitted from Sink.verbatim #202
Conversation
kwin
force-pushed
the
feature/simplify-verbatim-xhtml-markup
branch
from
8d72e9f
to
55f1695
Compare
There was a problem hiding this comment.
This is very nice. Can you test it down the line to Sitetools and Maven Site Plugin? Maven Fluido Skin needs to be changed for sure. Also have a look at this and test it: https://github.com/apache/maven-reporting-impl/blob/master/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
doxia-core/src/test/java/org/apache/maven/doxia/parser/AbstractParserTest.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| protected String getVerbatimSource() { | ||
| return null; // not supported in MD |
There was a problem hiding this comment.
Indeed, CommonMark does not support this. Eventually a link to https://spec.commonmark.org/0.31.2/#fenced-code-blocks might make sense?
There was a problem hiding this comment.
Not sure fenced code blocks are related. There is also https://spec.commonmark.org/0.31.2/#indented-code-block and both really refer to code only as there is no verbatim without code semantics.
There was a problem hiding this comment.
This isn't what a meant. I meant just add the link I have provided and explain why we return null since this is not a missing/broken test.
Emit either <pre> or <pre><code>. Add parser tests for verbatim content (for all parsers)
It works fine now together with apache/maven-fluido-skin#58. |
kwin
force-pushed
the
feature/simplify-verbatim-xhtml-markup
branch
from
55f1695
to
0621761
Compare
Use either
<pre>or<pre><code>.Add parser tests for verbatim content (for all parsers)