[DOXIA-734] Restore handling of XHTML 1.0 obsolete attributes #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
bugfix/restore-xhtml1-parser-capabilities-for-xdoc-fml
branch
from
da2dc30
to
6e9d899
Compare
|
I see, it will map on the fly from XHML1.0 to XHTML5. Not bad at all and something I can clearly live with. |
kwin
force-pushed
the
bugfix/restore-xhtml1-parser-capabilities-for-xdoc-fml
branch
2 times, most recently
from
fb55862
to
582065a
Compare
michael-o
reviewed
Mar 14, 2024
doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml1BaseParser.java
Show resolved
Hide resolved
kwin
force-pushed
the
bugfix/restore-xhtml1-parser-capabilities-for-xdoc-fml
branch
from
582065a
to
c42e640
Compare
kwin
force-pushed
the
bugfix/restore-xhtml1-parser-capabilities-for-xdoc-fml
branch
from
c42e640
to
dc29416
Compare
I don't think so, because the document is complying with the spec while using XHTML5 only attributes/elements (while supported) is not specified for XDoc 2.0. We should rather deprecate XDoc usage alltogether (but this is separate from this issue). |
michael-o
approved these changes
Mar 19, 2024
kwin
force-pushed
the
bugfix/restore-xhtml1-parser-capabilities-for-xdoc-fml
branch
from
dc29416
to
3d8d580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michael-o This is what I have in mind, at least for the most important obsolete attributes