[DOXIA-618] import tests from maven-site-plugin

[bertysentry]

• doxia-module-markdown: Re-incorporated integration tests from maven-site-plugin
• doxia-module-markdown: Merged DOXIA-616 integration tests into general

[bertysentry]

@michael-o @hboutemy This PR is in relation with the removal of some integration tests from maven-site-plugin. These tests have been re-incorporated in Doxia so that we make sure to catch potential problems early. Also, this allows us to implement new features or change the behavior of the parsers without having to modify tests that are too picky in maven-site-plugin (or test that are just become irrelevant).

[elharo]

running through jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-doxia/job/doxia-618/

[elharo]

Many failed tests:

https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-doxia/job/doxia-618/1/#showFailuresLink

[bertysentry]

@elharo Yes, this is weird. The build fails... on JDK7 only. To be honest, I don't see what I changed that could possibly break things... on JDK7 and still work in JDK8.

[elharo]

Perhaps try cutting this up into smaller pieces if possible.

[bertysentry]

Builds have been failing on JDK7 since this commit: b55285c

There are 2 error messages.

First error:

org.codehaus.plexus.component.repository.exception.ComponentLookupException: 
Unable to lookup component 'org.apache.maven.doxia.parser.Parser', it could not be started.
      role: org.apache.maven.doxia.parser.Parser
  roleHint: markdown
classRealm: plexus.core
-----------------------------------------------------
realm =    plexus.core
strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
Number of foreign imports: 0

-----------------------------------------------------

I really don't see what could have triggered this problem. It must be either in MarkdownParser.java or MarkdownParserTest.java

But since I haven't touched the component declaration, I don't understand what is wrong here.

2nd error message

at org.apache.maven.doxia.module.markdown.MarkdownParserTest.setUp(MarkdownParserTest.java:58)
Caused by: org.codehaus.plexus.component.repository.exception.ComponentLifecycleException: Error constructing component role: 'org.apache.maven.doxia.parser.Parser', implementation: 'org.apache.maven.doxia.module.markdown.MarkdownParser', role hint: 'markdown'
	at org.apache.maven.doxia.module.markdown.MarkdownParserTest.setUp(MarkdownParserTest.java:58)
Caused by: java.lang.ExceptionInInitializerError
	at org.apache.maven.doxia.module.markdown.MarkdownParserTest.setUp(MarkdownParserTest.java:58)
Caused by: java.util.regex.PatternSyntaxException: 
Illegal/unsupported escape sequence near index 97
\A^\s*(?:title|author|date|address|affiliation|copyright|email|keywords|language|phone|subtitle)\h*:\h*\V*\h*$\v+(?:^\h*[^:\v]+\h*:\h*\V*\h*$\v+)*
                                                                                                 ^
	at org.apache.maven.doxia.module.markdown.MarkdownParserTest.setUp(MarkdownParserTest.java:58)

This one I understand. The \h escape sequence in Regex appears to be not supported in Java 7, unfortunately.

So, this needs to be fixed in a separate issue. Sorry about that!

[bertysentry]

Before we spend too much time on this, do we want to spend time on compatibility with Java 7?
Java 7 is also what prevents us from using a more recent version of Flexmark, which requires Java 8.

[elharo]

Yes, we absolutely do need to fix this. We have to rollback the offending commit/PR before anything else can move forward.

[bertysentry]

Okay, I now understand the problem: the Pattern is compiled as a static constant in MarkdownParser. The Pattern.compile() fails because of the unknown \h escape sequence and then the class is therefore not initialized, and cannot be instantiated as a Plexus component.

I'll submit a new PR to fix this. How do you trigger builds on Jenkins? We could have caught this before.

Thanks!

[elharo]

Unfortunately only committers can trigger Jenkins builds so you have to ask one of us to do it for you. :-(

[bertysentry]

It's okay. I can reproduce the problem locally (and thus fix it).

[bertysentry]

Okay, so I rebased DOXIA-618 on master so we can see it now builds without any errors (pfew!)
@elharo Could you please trigger a build of this branch/PR?
Thanks!

[elharo]

The branches are a bit confusing but I'm running it through now

[bertysentry]

@elharo How is it going?
WRT branches, it's simply 1 commit on top of master. If you pulled this branch into your local git repo, you'll need to pull again as this branch had to be rebased.

[bertysentry]

Awesome, thank you!