Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf #28

Closed

Conversation

mabrarov
Copy link
Contributor

@mabrarov mabrarov commented Dec 6, 2020

[MEAR-182] - Don't add MANFIEST.mf Class-Path entry for EAR module if skipClassPathModification is true and original MANFIEST.mf of the EAR module artifact doesn't contain Class-Path entry. Refer to that comment in MEAR-182 for description of the bug which this pull request fixes.

@mabrarov mabrarov force-pushed the MEAR-182_undefined_Class-Path branch from dd780f1 to 8ecc190 Compare December 6, 2020 18:11
… skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry.
@mabrarov mabrarov force-pushed the MEAR-182_undefined_Class-Path branch from 8ecc190 to 30fbe32 Compare December 6, 2020 18:13
@mabrarov
Copy link
Contributor Author

mabrarov commented Dec 6, 2020

@hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release of Maven EAR Plugin.

@hboutemy
Copy link
Member

MEAR-182 https://issues.apache.org/jira/browse/MEAR-182 is an old issue closed for release 2.10
please create a new issue (we'll link it to MEAR-182), and update the commit (with rebasing, please, to have a simpler Git history)

@mabrarov
Copy link
Contributor Author

Declining in favor of pull request #29 with fixed source branch name.

@mabrarov mabrarov closed this Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants