Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEJB-129] Refactor - extract method #3

Closed
wants to merge 2 commits into from
Closed

[MEJB-129] Refactor - extract method #3

wants to merge 2 commits into from

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo force-pushed the extract branch 2 times, most recently from b5a0b49 to 83484a9 Compare April 13, 2020 09:45
@pzygielo pzygielo marked this pull request as draft April 13, 2020 10:42
@pzygielo pzygielo marked this pull request as ready for review April 13, 2020 10:47
@pzygielo
Copy link
Contributor Author

May I ask for review, please?

michael-o
michael-o requested changes May 19, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a JIRA issue for this code change.

src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java Show resolved Hide resolved
@pzygielo pzygielo changed the title Refactor - extract method [MEJB-129] Refactor - extract method May 20, 2020
@pzygielo pzygielo requested a review from michael-o May 23, 2020 07:37
@michael-o
Copy link
Member

Looking into...

asfgit pushed a commit that referenced this pull request May 23, 2020
@pzygielo @michael-o
[MEJB-129] Refactor IncludesExcludes to reduce code duplication
a2eefc2 
This closes #3
michael-o
michael-o approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied a few improvements, check out the branch. Waiting for Jenkins job.

@asfgit asfgit closed this in 90c83f0 May 23, 2020
@pzygielo pzygielo deleted the extract branch May 23, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pzygielo @michael-o