Manage default value in filters #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, can you please create an issue here https://issues.apache.org/jira/browse/MSHARED Just follow the guide https://maven.apache.org/guides/development/guide-helping.html Thanks |
eolivelli
requested changes
Jan 3, 2019
| @@ -121,4 +123,25 @@ public void testAtDollarExpression() | |||
|
|
|||
| assertEquals( " url=\"jdbc:oracle:thin:@DB_SERVER:DB_PORT:DB_NAME\"", IOUtil.toString( reader ) ); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testDefaultValue() | |||
There was a problem hiding this comment.
What about adding tests to cover syntax error cases? Or empty string as default...
|
Related issue is here : https://issues.apache.org/jira/browse/MSHARED-793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the good place to contribute, let me know :)
The goal is to manage defaut value like ${toto:tutu} where tutu is used when no value for toto is found.
It is the same behavior as Spring's PropertyPlaceholderConfigurer