Getting rid of deprecated baggage.

git-svn-id: https://svn.apache.org/repos/asf/maven/indexer/trunk@1372382 13f79535-47bb-0310-9956-ffa450edef68

indexer-artifact/src/main/java/org/apache/maven/index/artifact/Gav.java

@@ -93,33 +93,6 @@ public Gav( String groupId, String artifactId, String version )
         this( groupId, artifactId, version, null, null, null, null, null, false, null, false, null );
     }
 
-    /**
-     * Deprecated constructor, left here for backward compatibility. It simply delegates to other constructor and
-     * neglects the snapshot redundant parameter.
-     * 
-     * @deprecated The <code>boolean snapshot</code> parameter is simply neglected. Use the constructor without it.
-     * @param groupId
-     * @param artifactId
-     * @param version
-     * @param classifier
-     * @param extension
-     * @param snapshotBuildNumber
-     * @param snapshotTimeStamp
-     * @param name
-     * @param snapshot
-     * @param hash
-     * @param hashType
-     * @param signature
-     * @param signatureType
-     */
-    public Gav( String groupId, String artifactId, String version, String classifier, String extension,
-                Integer snapshotBuildNumber, Long snapshotTimeStamp, String name, boolean snapshot, boolean hash,
-                HashType hashType, boolean signature, SignatureType signatureType )
-    {
-        this( groupId, artifactId, version, classifier, extension, snapshotBuildNumber, snapshotTimeStamp, name, hash,
-            hashType, signature, signatureType );
-    }
-
     public Gav( String groupId, String artifactId, String version, String classifier, String extension,
                 Integer snapshotBuildNumber, Long snapshotTimeStamp, String name, boolean hash, HashType hashType,
                 boolean signature, SignatureType signatureType )

indexer-artifact/src/main/java/org/apache/maven/index/artifact/GavCalculator.java

@@ -31,14 +31,12 @@ public interface GavCalculator
      * Calculates GAV from provided <em>repository path</em>. The path has to be absolute starting from repository root.
      * If path represents a proper artifact path (conforming to given layout), GAV is "calculated" from it and is
      * returned. If path represents some file that is not an artifact, but is part of the repository layout (like
-     * maven-metadata.xml), or in any other case it returns null. TODO: some place for different levels of "validation"?
+     * maven-metadata.xml), or in any other case it returns null.
      * 
      * @param path the repository path
      * @return Gav parsed from the path
-     * @throws IllegalArtifactCoordinateException not throwing it anymore, here just for backward compatibility.
      */
-    Gav pathToGav( String path )
-        throws IllegalArtifactCoordinateException;
+    Gav pathToGav( String path );
 
     /**
      * Reassembles the repository path from the supplied GAV. It will be an absolute path.

indexer-artifact/src/test/java/org/apache/maven/index/artifact/M2GavCalculatorTest.java

@@ -571,7 +571,6 @@ public void testNegGav()
         throws Exception
     {
         Gav gav;
-        String path;
 
         // NEXUS-4132
         gav =