-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7667] Fix Bootstrap IT #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change hunts down m-install-p and m-deploy-p versions from tested Maven (the one bound in default lifecycle) and resolves them and their dependencies. This makes IT pass for me with both, non updated Maven 3.9.0 and updated 3.9.0 re lifecycle plugins. The ITs exectute this mojo in Bootstrap IT that executes with pom that has packaging=pom, but the m-install-p and m-deploy-p are still present. The "proper" fix would be to somehow grab the versions of ALL plugins in all lifecycles burned in currently tested Maven, but unsure how to achieve that.
...ort/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java
Outdated
Show resolved
Hide resolved
This fixes the original issue, but now (with apache/maven#956) we face other issue: all the ITs that use maven-plugin packaging and do verifier.verifyErrorFreeLog will fail, as m-plugin-p emits ERRORs that should be WARNs instead... Example:
This is logged as https://issues.apache.org/jira/browse/MPLUGIN-452 |
slawekjaranowski
approved these changes
Jan 12, 2023
gnodet
approved these changes
Jan 12, 2023
Finish the PoC, split properly and explain what is happening,
...ort/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java
Show resolved
Hide resolved
slawekjaranowski
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends Bootstrap IT (1st IT that fills in local repo) to hunt down some plugins that are bound in lifecycles provided by Maven under test.
Changes:
https://issues.apache.org/jira/browse/MNG-7667