[MINVOKER-313] Get rid of maven-artifact-transfer - InstallMojo refactor #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor InstallMojo to use Resolver API - add possibility to configure scope for installing artifacts - remove maven-artifact-transfer and maven-common-artifact-filters from dependencies
cstamas
reviewed
Jan 31, 2023
cstamas
approved these changes
Jan 31, 2023
gnodet
approved these changes
Jan 31, 2023
This was referenced Jan 31, 2023
copybara-service bot
pushed a commit
to google/auto
that referenced
this pull request
Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with this message: ``` Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1] ``` Setting `localRepositoryPath` fixes this. I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly. RELNOTES=n/a PiperOrigin-RevId: 510172220
copybara-service bot
pushed a commit
to google/auto
that referenced
this pull request
Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with the message here: ``` Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1] ``` Setting `localRepositoryPath` fixes this. I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly. But it has always been [recommended](https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#localRepositoryPath) to use a non-default `localRepositoryPath` anyway. RELNOTES=n/a PiperOrigin-RevId: 510172220
copybara-service bot
pushed a commit
to google/auto
that referenced
this pull request
Feb 16, 2023
The upgrade to version 3.5.0 of `maven-invoker-plugin` caused this project to fail, with the message here: ``` Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.0:install (integration-test) on project auto-value: Failed to install artifact com.google.auto:auto-common:jar:1.2.1: cannot install /home/runner/.m2/repository/com/google/auto/auto-common/1.2.1/auto-common-1.2.1.jar to same path -> [Help 1] ``` Setting `localRepositoryPath` fixes this. I believe the change in behaviour was caused by [this PR](apache/maven-invoker-plugin#174), which may have broken other projects similarly. But it has always been [recommended](https://maven.apache.org/plugins/maven-invoker-plugin/integration-test-mojo.html#localRepositoryPath) to use a non-default `localRepositoryPath` anyway. RELNOTES=n/a PiperOrigin-RevId: 510177767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MINVOKER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.