Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localized format to avoid space before colon in English #96

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Use localized format to avoid space before colon in English #96

merged 1 commit into from
Feb 1, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Feb 1, 2022

No description provided.

@michael-o
Copy link
Member

If you see this, you know it has been a Frenchman.

@michael-o michael-o self-requested a review February 1, 2022 16:18
@pzygielo pzygielo marked this pull request as ready for review February 1, 2022 17:01
@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 1, 2022

If you see this, you know it has been a Frenchman.

Now I do, indeed. Before - I had no idea about such rule.

@pzygielo
Copy link
Contributor Author

pzygielo commented Feb 1, 2022

I suppose IT

maven-invoker-plugin/src/it/invoker-report/pom.xml

Line 26 in e7fd10d

<artifactId>invoker-report</artifactId>
kind of shows the (tiny) difference

before after
invoker-report-before invoker-report-after

Not sure if it deserves the update (it would need to consider localization I think).

michael-o
michael-o reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@michael-o michael-o merged commit 292df99 into apache:master Feb 1, 2022
@pzygielo pzygielo deleted the space branch February 1, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
3 participants
@pzygielo @michael-o @slawekjaranowski