fix some its.. disable a test which need network access which is wrong

Signed-off-by: olivier lamy <olamy@apache.org>
apache · Jun 14, 2019 · 5bbfc89 · 5bbfc89
1 parent 58c0c6d
commit 5bbfc89
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/src/it/projects/MJAVADOC-325/invoker.properties b/src/it/projects/MJAVADOC-325/invoker.properties
@@ -19,4 +19,4 @@ invoker.goals=clean javadoc:javadoc
 # Javadoc 12+ fails: 
 # The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/1.5.0/docs/api/ are in the unnamed module.
 # Unrelated to the issue
-invoker.java.version= 12-
+invoker.java.version= 11-
diff --git a/src/it/projects/MJAVADOC-325/pom.xml b/src/it/projects/MJAVADOC-325/pom.xml
@@ -52,5 +52,4 @@
       </plugins>
     </pluginManagement>
   </build>
-
 </project>
diff --git a/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml b/src/it/projects/MJAVADOC-575_source8-module-info/pom.xml
@@ -66,6 +66,7 @@
         </executions>
         <configuration>
           <source>8</source>
+          <detectJavaApiLink>false</detectJavaApiLink>
         </configuration>
       </plugin>
     </plugins>

diff --git a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java
@@ -57,6 +57,7 @@
 import org.codehaus.plexus.util.FileUtils;
 import org.codehaus.plexus.util.StringUtils;
 import org.junit.AssumptionViolatedException;
+import org.junit.Ignore;
 import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager;
 
 /**
@@ -920,9 +921,12 @@ public void testJdk6()
      *
      * @throws Exception if any
      */
+    @Ignore("We don't really want to have unit test which need internet access")
     public void testProxy()
         throws Exception
     {
+        // ignore test as annotation doesn't ignore anything..
+        if(true) return;
         Settings settings = new Settings();
         Proxy proxy = new Proxy();