Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enforce assertions in the native image so that we can remove volatile…
… from some TerminalOutput fields
- Loading branch information
Showing
2 changed files
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52f46a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppalaga I've just hit a problem with the assertions enabled.
The read input loop does send message directly and causes an assertion error : https://github.com/mvndaemon/mvnd/blob/52f46a3e9037d1a2b5e8d636ebbe54f0eb9c6e68/common/src/main/java/org/jboss/fuse/mvnd/common/logging/TerminalOutput.java#L347-L349
You can easily reproduce it by hitting
+
during any build.52f46a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
52f46a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then feel free to revert 52f46a3. Now we know that the vars can be read from threads other than main.
52f46a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #205 for a fix