Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] synchronization of code copied from Maven core #609

Open
slawekjaranowski opened this issue Mar 18, 2022 · 2 comments
Open

Comments

@slawekjaranowski
Copy link
Member

We can find classes like:
https://github.com/apache/maven-mvnd/blob/master/daemon/src/main/java/org/mvndaemon/mvnd/plugin/CliMavenPluginManager.java

Where we have comments:

This file is based on maven DefaultMavenPluginManager and changed in order
to better support parallel builds. See #310

But the based on class can change ... like in: apache/maven#285

Should it be synchronized, tracked in some ways?

@gnodet
Copy link
Contributor

gnodet commented Mar 18, 2022

Ideally, the rewritten maven classes would be adapted to either support mvnd use cases or to allow mvnd to derive a class instead of having to rewrite it.

@gnodet
Copy link
Contributor

gnodet commented May 3, 2022

#633 has removed a few classes already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants