Drop Maven dupe classes #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That has been fixed in Maven version used by mvnd. Last bit is MavenCli/DaemonCli that is currently "almost" a copy, but they do not share any code.
gnodet
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That has been fixed in Maven version used by mvnd.
Last bit is MavenCli/DaemonCli that is currently
"almost" a copy, but they do not share any code.
On master DefaultModelBuilder and DefaultModelBuilderFactory (coming from maven. not copied in mvnd) are "disconnected", as one method is missing from DefaultModelBuilder.