More script changes #1020
Merged
More script changes #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just do not push: this means one can locally verify the outcome, and push (for now manually).
This does not cause any harm, as if mvn is released (is in central) the settings repo will not be used at all (as central repo is before staging repo).
gnodet
approved these changes
Jun 14, 2024
gnodet
reviewed
Jun 14, 2024
| git push origin mvnd-1.x | ||
| # git push origin mvnd-1.x | ||
|
|
||
| # NOTE: Manually push once done: git push origin mvnd-1.x --tags |
There was a problem hiding this comment.
Can we echo that somehow ?
There was a problem hiding this comment.
added reminder message at end
gnodet
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
release-build.sh: Just do not push. This allows one to locally verify the outcome, and push (for now manually likegit push origin mvnd-1.x --tags). Added reminder message.release.yaml: whenever mvn would resolve deps, make sure release settings XML is present. It does not stir anything if Maven is in Central, but as in this moment, maven is still staged only.