Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure our CachingProjectBuilder is used, fixes #218 #228

Merged
merged 1 commit into from Nov 17, 2020
Merged

Make sure our CachingProjectBuilder is used, fixes #218 #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions daemon/src/main/java/org/apache/maven/project/CachingProjectBuilder.java
View file
Open in desktop
Expand Up @@ -75,6 +75,7 @@
import org.eclipse.aether.repository.WorkspaceRepository;
import org.eclipse.aether.resolution.ArtifactRequest;
import org.eclipse.aether.resolution.ArtifactResult;
import org.eclipse.sisu.Priority;
import org.eclipse.sisu.Typed;

/**
Expand All @@ -86,6 +87,7 @@
@Named
@Singleton
@Typed(ProjectBuilder.class)
@Priority(10)
public class CachingProjectBuilder
implements ProjectBuilder {

Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/test/java/org/mvndaemon/mvnd/it/NewManagedModuleNativeIT.java
View file
Open in desktop
Expand Up @@ -83,7 +83,7 @@ void upgrade() throws IOException, InterruptedException {
{
final TestClientOutput output = new TestClientOutput();
cl.execute(output, "clean", "install", "-e", "-B", "-ntp")
.assertFailure(); // Switch back to assertSuccess() once https://github.com/mvndaemon/mvnd/issues/218 is fixed
.assertSuccess();
}
Assertions.assertThat(registry.getAll().size()).isEqualTo(1);

Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/test/java/org/mvndaemon/mvnd/it/UpgradesInBomNativeIT.java
View file
Open in desktop
Expand Up @@ -77,7 +77,7 @@ void upgrade() throws IOException, InterruptedException {
{
final TestClientOutput output = new TestClientOutput();
cl.execute(output, "clean", "install", "-e")
.assertFailure(); // Switch back to assertSuccess() once https://github.com/mvndaemon/mvnd/issues/218 is fixed
.assertSuccess();
}
Assertions.assertThat(registry.getAll().size()).isEqualTo(1);

Expand Down