Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cut sha256 in release workflow #539

Closed
wants to merge 1 commit into from

Conversation

vorburger
Copy link
Member

This makes it much easier to actually use the checksum in an automated download script by using sha256sum -c mvnd*.sha256 mvnd*.zip.

This makes it much easier to actually use the checksum in an automated download script by using `sha256sum -c mvnd*.sha256 mvnd*.zip`.
@vorburger
Copy link
Member Author

use the checksum in an automated download script

such as e.g. https://github.com/vorburger/vorburger-dotfiles-bin-etc/blob/master/install-github.sh

@ecki
Copy link

ecki commented Dec 17, 2021

Is this compatible with the maven repository format?

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was adding the checksums to make some package manager happy. Unfortunately, I do not remember anymore which one of Brew, SDKMAN or Chocolatey was that. Let's try like this.

The CI does not work for some reason. Let me check.

@ppalaga
Copy link
Contributor

ppalaga commented Dec 17, 2021

Let me check.

I cannot :/ after the repo moved to ASF.

@olamy
Copy link
Member

olamy commented Dec 17, 2021

Let me check.

I cannot :/ after the repo moved to ASF.

what sort of karma do you need?

@gnodet
Copy link
Contributor

gnodet commented Dec 17, 2021

Let me check.

I cannot :/ after the repo moved to ASF.

what sort of karma do you need?

commitership ? I suppose Peter lost his write access to the code tree during the move given he is not a Maven committer.

@olamy
Copy link
Member

olamy commented Dec 17, 2021

Let me check.

I cannot :/ after the repo moved to ASF.

what sort of karma do you need?

commitership ? I suppose Peter lost his write access to the code tree during the move given he is not a Maven committer.

Ah yes makes sense.
I will try to fix that ;)

@aalmiray
Copy link
Contributor

FWIW #574 addresses this with JReleaser

@gnodet
Copy link
Contributor

gnodet commented Apr 29, 2022

This looks pretty standard to cut the SHA checksums.
I think it has always been the case on maven central and it looks like a common expectation.

@gnodet gnodet closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants