Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mvnd verify as example instead of mvnd clean install #734

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Use mvnd verify as example instead of mvnd clean install #734

merged 1 commit into from
Dec 14, 2022

Conversation

plamentotev
Copy link
Contributor

There is wide spread misconception that in order to build a Maven project the command is mvn clean install.

It would be better to promote the right way (in the vast majority of the cases) to build a Maven project.

mvnd verify aligns with Maven documentation as well, where the example command is mvn verify.

p.s. Sorry for the nitpicking and thanks for the hard work. The project is amazing. Just want to fix all mvn clean install examples where I see them 馃槂

There is wide spread misconception that in order to build a Maven project
the command is `mvn clean install`.

It would be better to promote the right way (in the vast majority of the cases)
to build a Maven project.

`mvnd verify` aligns with Maven documentation as well,
where the example command is `mvn verify`.
@plamentotev plamentotev changed the title Improve the README file Use mvnd verify as example instead of mvnd clean install Nov 11, 2022
@cstamas
Copy link
Member

cstamas commented Nov 11, 2022

Stll, the mvn clean install works 100% always, while mvn verify may not, in cases like "resume from", or even if you have some nastiy plugin in picture, that expects something to be resolved from local repo (and neglects reactor), OR, when you build the plugin that is also used in same build, like here.

So, no, there is not s/install/verify that is always applicable....

@cesarhernandezgt
Copy link

Agree with @cstamas. I've seen cases when plugins are attached to specific phases and this gets even more interesting on multimodule projects. So finally doing a mvn clean install gave me the output the maintainers of the project(s) would take as valid.

@bmarwell
Copy link

I disagree. If mvnd verify does not work, let's better fix the plugins instead.

I agree it's not always applicable (at this point in time), but let's promote the option which SHOULD be used most of the time.

+1 for this PR.

@gnodet gnodet merged commit 6482812 into apache:master Dec 14, 2022
gnodet pushed a commit that referenced this pull request Jan 6, 2023
There is wide spread misconception that in order to build a Maven project
the command is `mvn clean install`.

It would be better to promote the right way (in the vast majority of the cases)
to build a Maven project.

`mvnd verify` aligns with Maven documentation as well,
where the example command is `mvn verify`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants