Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the default (non-native) build work again #808

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Make the default (non-native) build work again #808

merged 2 commits into from
Mar 12, 2023

Conversation

psiroky
Copy link
Contributor

@psiroky psiroky commented Mar 10, 2023

  • mvn clean install currently fails with
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR] org.mvndaemon.mvnd.it.ExtensionWithApiTest.pluginCanAccessExtensionApi
[ERROR]   Run 1: ExtensionWithApiTest.pluginCanAccessExtensionApi » IllegalState mvnd executable does not exist: <...>/maven-mvnd/dist-m39/target/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd
[ERROR]   Run 2: ExtensionWithApiTest.pluginCanAccessExtensionApi » IllegalState mvnd executable does not exist: <...>/maven-mvnd/dist-m39/target/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd
[ERROR]   Run 3: ExtensionWithApiTest.pluginCanAccessExtensionApi » IllegalState mvnd executable does not exist: <...>/maven-mvnd/dist-m39/target/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd
[ERROR]   Run 4: ExtensionWithApiTest.pluginCanAccessExtensionApi » IllegalState mvnd executable does not exist: <...>/maven-mvnd/dist-m39/target/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd
[ERROR]   Run 5: ExtensionWithApiTest.pluginCanAccessExtensionApi » IllegalState mvnd executable does not exist: <...>/maven-mvnd/dist-m39/target/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd

  • the renamed test is supposed to use the native binary, but it was being picked up by surefire, because of its name. For non-native builds (e.g. without -Pnative) the test would fail as the native binary does not exist

  • I also tried to create a non-native test (following the same pattern as with the other tests), but that actually fails with a somewhat cryptic guice error. I am not sure if this test is supposed to work in non-native mode. If so, some additional fixes would be needed.

Error details 
ExecutionFailure{projectId='plugin-user', halted=true, exception='org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo (default-cli) on project plugin-user: Execution default-cli of goal org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo failed: Unable to load the mojo 'mojo' (or one of its required components) from the plugin 'org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT''}
ProjectLogMessage{projectId='plugin-user', message='[DEBUG] FAILURE build of project org.mvndaemon.mvnd.test.extension.with.api:plugin-user'}
ProjectLogMessage{projectId='plugin-user', message='[DEBUG] Builder state: blocked=0 finished=1 ready-or-running=0 '}
ProjectLogMessage{projectId='plugin-user', message='[INFO] ------------------------------------------------------------------------'}
ProjectLogMessage{projectId='plugin-user', message='[INFO] BUILD FAILURE'}
ProjectLogMessage{projectId='plugin-user', message='[INFO] ------------------------------------------------------------------------'}
ProjectLogMessage{projectId='plugin-user', message='[INFO] Total time:  0.035 s (Wall Clock)'}
ProjectLogMessage{projectId='plugin-user', message='[INFO] Finished at: 2023-03-10T17:02:07+01:00'}
ProjectLogMessage{projectId='plugin-user', message='[INFO] ------------------------------------------------------------------------'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Failed to execute goal org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo (default-cli) on project plugin-user: Execution default-cli of goal org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo failed: Unable to load the mojo 'mojo' (or one of its required components) from the plugin 'org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT': com.google.inject.ProvisionException: Unable to provision, see the following errors:'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] 1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at LocatorWiring'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]  but TheMojo.api(TheMojo.java:28) is not @Nullable'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   at LocatorWiring'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   at TheMojo.api(TheMojo.java:28)'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]       \_ for field api'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   while locating TheMojo'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   at ClassRealm[plugin>org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT, parent: URLClassLoader@c51f883]'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]       \_ installed by: WireModule -> PlexusBindingModule'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   while locating Mojo annotated with @Named("org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo")'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Learn more:'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] 1 error'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] ======================'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Full classname legend:'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] ======================'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] LocatorWiring:       "org.eclipse.sisu.wire.LocatorWiring"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Mojo:                "org.apache.maven.plugin.Mojo"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Named:               "com.google.inject.name.Named"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] PlexusBindingModule: "org.eclipse.sisu.plexus.PlexusBindingModule"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] TheMojo:             "org.mvndaemon.mvnd.test.extension.with.api.plugin.TheMojo"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] URLClassLoader:      "java.net.URLClassLoader"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] WireModule:          "org.eclipse.sisu.wire.WireModule"'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] ========================'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] End of classname legend:'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] ========================'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]       role: org.apache.maven.plugin.Mojo'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR]   roleHint: org.mvndaemon.mvnd.test.extension.with.api:plugin:0.0.1-SNAPSHOT:mojo'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] -> [Help 1]'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] Re-run Maven using the -X switch to enable full debug logging.'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] '}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] For more information about the errors and possible solutions, please read the following articles:'}
ProjectLogMessage{projectId='plugin-user', message='[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException'}

@psiroky
Make the default (non-native) build work again
ca4bdd0 
 * the renamed test is supposed to use the native binary, but it was
   being picked up by surefire, because of its name. For non-native builds
   (e.g. without -Pnative) the test would fail as the native
   binary does not exist
@psiroky
Copy link
Contributor Author

psiroky commented Mar 10, 2023

Would it make sense to include a non-native build as part of the CI checks? Or that more like nice to have, and if it gets occasionally broken it is not really a big deal and can be fixed when encountered?

@gnodet
Copy link
Contributor

gnodet commented Mar 12, 2023

Would it make sense to include a non-native build as part of the CI checks? Or that more like nice to have, and if it gets occasionally broken it is not really a big deal and can be fixed when encountered?

It would definitely be better to include non-native builds.

@psiroky
Copy link
Contributor Author

psiroky commented Mar 12, 2023 •
edited
Loading

Would it make sense to include a non-native build as part of the CI checks? Or that more like nice to have, and if it gets occasionally broken it is not really a big deal and can be fixed when encountered?

It would definitely be better to include non-native builds.

Let me see if I can create a GitHub workflow for that, as part of this PR - as that would actually "prove" the fix is working.

Edit: default (non-native) CI build added. It seems it works as expected.

@gnodet gnodet added this to the 1.0.0-m5 milestone Mar 12, 2023
@gnodet gnodet merged commit b0b7115 into apache:master Mar 12, 2023
@gnodet
Copy link
Contributor

gnodet commented Mar 12, 2023

Awesome, thx a ton !

@psiroky psiroky deleted the fix-native-it-name branch March 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0-m6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psiroky @gnodet