Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore smart-builder core extension, if present. #916

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Feb 20, 2024

Fixes #912

@cstamas cstamas requested a review from gnodet February 20, 2024 10:51
@cstamas cstamas self-assigned this Feb 20, 2024
@cstamas cstamas requested a review from ppalaga February 20, 2024 10:54
@wendigo
Copy link

wendigo commented Feb 21, 2024

@gnodet can we get this merged and expect new release soon :)?

@cstamas
Copy link
Member Author

cstamas commented Mar 29, 2024

Do not merge pls, I want to extend this pr: with user configurable GA list to ignore (where smart builder is present "by default").

@cstamas cstamas requested a review from gnodet March 29, 2024 17:10
@cstamas
Copy link
Member Author

cstamas commented Mar 29, 2024

@ppalaga @gnodet @wendigo pls review

@cstamas
Copy link
Member Author

cstamas commented Apr 13, 2024

ping

@cstamas cstamas merged commit a1ac666 into apache:master Apr 17, 2024
4 checks passed
@cstamas cstamas deleted the issue-912 branch April 17, 2024 20:04
@cstamas
Copy link
Member Author

cstamas commented Apr 20, 2024

[INFO] ------------------------------------------------------------------------
[ERROR] class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f)java.lang.ClassCastException: class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f)
    at io.takari.maven.builder.smart.DependencyGraph.fromMaven (DependencyGraph.java:40)
    at io.takari.maven.builder.smart.SmartBuilder.build (SmartBuilder.java:88)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.DaemonMavenCli.execute (DaemonMavenCli.java:858)
    at org.apache.maven.cli.DaemonMavenCli.doMain (DaemonMavenCli.java:253)
    at org.apache.maven.cli.DaemonMavenCli.main (DaemonMavenCli.java:230)
    at org.mvndaemon.mvnd.daemon.Server.handle (Server.java:612)
    at org.mvndaemon.mvnd.daemon.Server.client (Server.java:288)
    at org.mvndaemon.mvnd.daemon.Server.lambda$accept$2 (Server.java:250)
    at java.lang.Thread.run (Thread.java:1570)
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

Also,

mvnd clean install -e -Dmvnd.coreExtensionsExclude=io.takari.maven:takari-smart-builder

works but seems kinda default value is ignored?

@gnodet @ppalaga

@wendigo
Copy link

wendigo commented Apr 20, 2024

Just tested the master build with Trino and it seems to ignore the default property value for MVND_CORE_EXTENSIONS_EXCLUDE while the explicitly passed -Dmvnd.coreExtensionsExclude works as expected.

@cstamas
Copy link
Member Author

cstamas commented Apr 20, 2024

Def value handling here #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect smart builder in .mvn/extensions.xml and ignore it
3 participants