Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Override and make methods static #16

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Add missing @Override and make methods static #16

merged 1 commit into from
Aug 31, 2019

Conversation

gaul
Copy link
Member

@gaul gaul commented Oct 28, 2018

Found via error-prone.

@gaul
Copy link
Member Author

gaul commented Aug 30, 2019

Does anything block merging this?

@rfscholte
Copy link
Contributor

Does anything block merging this?

Time and resources

@Tibor17 Tibor17 self-requested a review August 31, 2019 10:44
@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

LGTM

@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

@rfscholte
Not sure how about you, but I started the build in few seconds and seen changes (static private method and one Override annotation).

@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

Build passed, merging...

@Tibor17 Tibor17 merged commit 8430e4a into apache:master Aug 31, 2019
@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

@gaul Thx for contributing. You are welcome with new pullrequests.

@gaul gaul deleted the error-prone branch August 31, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tibor17 Tibor17 Awaiting requested review from Tibor17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gaul @rfscholte @Tibor17