MPLUGIN-511 add plugin requirements history detection #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Mar 6, 2024
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java
Outdated
Show resolved
Hide resolved
...n-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/RequirementsHistory.java
Show resolved
Hide resolved
michael-o
requested changes
Mar 12, 2024
| @@ -93,6 +110,9 @@ public class PluginReport extends AbstractMavenReport { | |||
| @Parameter | |||
| private List<RequirementsHistory> requirementsHistories = new ArrayList<>(); | |||
|
|
|||
| @Parameter(defaultValue = "[0,)") | |||
| private String detectRequirementsHistory; | |||
There was a problem hiding this comment.
The naming includes to be boolean, but is string. Weird.
There was a problem hiding this comment.
yes, it looked strange, but I did not precisely see why :)
renamed to requirementsHistoryDetectRange
| MavenProject versionProject = buildMavenProject(v); | ||
| RequirementsHistory requirements = RequirementsHistory.discoverRequirements(versionProject); | ||
| requirementsHistories.add(requirements); | ||
| getLog().info("- " + requirements); |
There was a problem hiding this comment.
if you prefer: added 2 spaces
...n-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/RequirementsHistory.java
Show resolved
Hide resolved
...n-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/RequirementsHistory.java
Show resolved
Hide resolved
michael-o
requested changes
Mar 13, 2024
| * @since 3.12.0 | ||
| */ | ||
| @Parameter(defaultValue = "[0,)") | ||
| private String requirementsHistoryDetectRange; |
There was a problem hiding this comment.
requirementsHistoryDetectionRange
...n-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/RequirementsHistory.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.