Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPLUGIN-396] Allow @Deprecated annotation without javadoc tag #87

Merged
merged 1 commit into from May 27, 2022
Merged

[MPLUGIN-396] Allow @Deprecated annotation without javadoc tag #87

merged 1 commit into from May 27, 2022

Conversation

slawekjaranowski
Copy link
Member

No description provided.

michael-o
michael-o reviewed May 23, 2022
View reviewed changes
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/invoker.properties Outdated Show resolved Hide resolved
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/invoker.properties Outdated Show resolved Hide resolved
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/pom.xml Outdated Show resolved Hide resolved
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/expected-help.txt Outdated Show resolved Hide resolved
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/verify.groovy Show resolved Hide resolved
...g/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java Outdated Show resolved Hide resolved
...g/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member Author

oh copy paste test ... 😄

michael-o
michael-o reviewed May 23, 2022
View reviewed changes
maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/src/main/java/test/MyMojo.java
*/
@Deprecated
@Parameter
private String deprecatedParam;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Add this one as well:

    /**
     * Parameter description in javadoc.
     *
     * @deprecated I don't like this.
     */
    @Deprecated
    @Parameter
    private String deprecatedParam2;

@michael-o michael-o self-requested a review May 23, 2022 21:00
@slawekjaranowski
Copy link
Member Author

kindly ping @michael-o

@slawekjaranowski slawekjaranowski merged commit 7803265 into master May 27, 2022
@slawekjaranowski slawekjaranowski deleted the MPLUGIN-396 branch May 27, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slawekjaranowski @michael-o