This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[MSITE-705] Wagon logs displayed only if debug mode activated #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it really needed to deploy to a mock FTP server for the test? The |
|
@Tunaki : It is to be closest to the original issue (even if this is not SFTP, a little bit more complex to mock). The FTP/SFTP logs are different => I try to found a common pattern for assert. But I agree, a push on local file is more simple & sustainable. I can change or provide a new PR ASAP based on this use case if considered as recevable for patch inclusion. |
|
I went ahead and updated the PR, will push this. Thanks! |
|
OK, many thanks. |
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2016
…sftp... The debug listener on the Wagon instance is only added if we're running Maven in debug mode. This closes #95. git-svn-id: https://svn.apache.org/repos/asf/maven/plugins/trunk@1764759 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSITE-705 : William Kemper patch + IT inclusion