MRELEASE-1053 populate scm info from current module instead of execution root

[kwin]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

This probably needs some unit/integration test, but I am not familiar enough with the code base to come up with some. The fix itself is trivial.

[kwin]

@rfscholte Can you have a look as this seems to be a regression of 419114d#diff-dc91aa6b8566714aa9abc3cd3740cfd26c5f38e1ee68dcc9dcbb4df6f8701fcb.

[rfscholte]

Can you extend https://github.com/apache/maven-release/tree/master/maven-release-plugin/src/it/projects/prepare/regular-multi-module with an extra module and update verify.groovy?

[kwin]

Can you extend https://github.com/apache/maven-release/tree/master/maven-release-plugin/src/it/projects/prepare/regular-multi-module with an extra module and update verify.groovy?

Done in 38939c3.

[rfscholte]

Ah, you need a flat structure. In that case it is better to adjust flat-multi-module and keep this one as it (as it is the most common setup)

[kwin]

flat-multi-module

This module currently uses the parent project as reactor root project. This particular issue only happens in case both projects are not the same. Should I really adjust flat-multi-module accordingly to add a reactor root pom.xml at https://github.com/apache/maven-release/tree/master/maven-release-plugin/src/it/projects/prepare/flat-multi-module?

[rfscholte]

So better introduce a new it-project?

[kwin]

You tell me, please. I don't know the original intent of the existing ITs.

[rfscholte]

I hadn't looked at any IT, just trying to match based on the description. If it is just about adding a sub-module, that would be fine, but if it changes inheritence or execution root, there should be a new IT.
I want to prevent a huge list of ITs where some verification details could easily be combined.

[kwin]

there should be a new IT.

Done in 7b5c74b

[kwin]

@rfscholte Would it possible for you to review the PR and comment or merge? Really looking forward to a new version of m-release-p with this issue fixed...

[kwin]

@rfscholte Gentle ping

[rfscholte]

child.project.url.inherit.append.path="false" needs to be removed here too.

[kwin]

removed in 70bd5be

[rfscholte]

Merged with 67dc2f8
Thanks!