Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-9] Managed dependencies are not honoured when resolving a … #145

Closed
wants to merge 1 commit into from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 18, 2022

…dependency graph

@gnodet
Copy link
Contributor Author

gnodet commented Jan 18, 2022

This PR actually fixes https://issues.apache.org/jira/projects/MNG/issues/MNG-7003 but it may also broke other test cases. I'll run the IT suite on maven 4 to check.

@michael-o
Copy link
Member

Here is the original fix: ChristianSchulte@ed4322f Please compare and judge.

@gnodet
Copy link
Contributor Author

gnodet commented Jan 18, 2022

Here is the original fix: ChristianSchulte@ed4322f Please compare and judge.

Yes, I saw it. Fwiw, the issue is not exactly the same as my problem lies in the DependencyManager (i.e. the version in this use case) and not in the DependencySelector (which decides if a transitive dependency should be added or ignored). Both are problems related to dependency management and both issues can be covered by the MRESOLVER-9 title.
That said, I'm going to investigate this original fix and try to cherry-pick it at the same time.

@michael-o
Copy link
Member

Thanks, looking forward to.

@gnodet
Copy link
Contributor Author

gnodet commented Jan 20, 2022

I've opened #146 to use a different jira issue.

@gnodet gnodet closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants